Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: render valid request methods only #261

Merged
merged 2 commits into from Oct 16, 2023
Merged

fix: render valid request methods only #261

merged 2 commits into from Oct 16, 2023

Conversation

hanspagel
Copy link
Member

The path object item has more keys than just request methods:
https://spec.openapis.org/oas/v3.1.0#pathItemObject

Let’s not iterate over the other keys.

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023 •
edited

⚠️ No Changeset found

Latest commit: b9ec664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hanspagel hanspagel mentioned this pull request Oct 16, 2023
Closed
marclave
marclave approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@marclave marclave left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! We can make a GitHub issue based on my one comment but let's get this merged after the conflicts are fixed✨

packages/swagger-parser/src/helpers/parseSwaggerFile.ts Outdated Show resolved Hide resolved
@hanspagel hanspagel force-pushed the fix/render-request-methods-only branch from a9d1bde to 92c8564 Compare October 16, 2023 14:52
@hanspagel hanspagel merged commit 33ce92e into main Oct 16, 2023
2 checks passed
@hanspagel hanspagel deleted the fix/render-request-methods-only branch October 16, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclave marclave marclave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanspagel @marclave