Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download spec #362

Merged
merged 13 commits into from
Oct 26, 2023
Merged

feat: download spec #362

merged 13 commits into from
Oct 26, 2023

Conversation

hanspagel
Copy link
Member

@hanspagel hanspagel commented Oct 24, 2023

This PR adds a download link to the reference:

Screenshot 2023-10-26 at 11 33 41

It also includes some minor changes:

  • adds footerBelowSidebar as a deprecated prop
  • Github -> GitHub
  • refactors how the data flows between the swagger editor and the reference

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: b8e846f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@scalar/api-reference Patch
@scalar/swagger-editor Patch
@scalar/api-client Patch
@scalar/fastify-api-reference Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cameronrohani
Copy link
Contributor

Added to introduction, just need to clean up unused code
image

@hanspagel hanspagel marked this pull request as ready for review October 26, 2023 09:38
Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME work @hanspagel

@marclave marclave merged commit 2f0b2f0 into main Oct 26, 2023
2 checks passed
@marclave marclave deleted the feat/download-spec branch October 26, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants