Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbt 0.13.9 scala 2.10.5 not backward compatibility #156

Closed
ajozwik opened this issue Aug 12, 2015 · 5 comments · Fixed by #157
Closed

sbt 0.13.9 scala 2.10.5 not backward compatibility #156

ajozwik opened this issue Aug 12, 2015 · 5 comments · Fixed by #157

Comments

@ajozwik
Copy link

ajozwik commented Aug 12, 2015

If class contains < the scalastyle parser failed with error:

Expected token RBRACKET but got Token(XML_START_OPEN,<,63,<)

Infected file:

case class EnumWrapper[E <: Enum[E]](a: E

Maybe it affects parser, see:
scala/scala#4185

Environment:
sbt 0.13.9
scala 2.10.5 (used by sbt 0.13.9)
@ajozwik ajozwik changed the title sbt 0.13.9 scala 2.10.5 not backward compatibly sbt 0.13.9 scala 2.10.5 not backward compatibility Aug 12, 2015
@SethTisue
Copy link
Contributor

see sbt/sbt#2089

@mrerrormessage mrerrormessage mentioned this issue Aug 13, 2015
Merged
This was referenced Aug 21, 2015
Closed
Closed
kciesielski added a commit to kciesielski/scalastyle that referenced this issue Aug 28, 2015
@kciesielski
Switch to scalariform 0.1.7
8f13816 
- This fixes scalastyle#156
@kciesielski kciesielski mentioned this issue Aug 28, 2015
Merged
@travisbrown travisbrown mentioned this issue Aug 28, 2015
Merged
@fthomas fthomas mentioned this issue Sep 1, 2015
Closed
fthomas added a commit to fthomas/alleycats that referenced this issue Sep 1, 2015
@fthomas
Disable scalastyle until it uses a newer scalariform version
5effd98 
see scalastyle/scalastyle#156
@ahirreddy
Copy link
Contributor

I used this snippet to fix it for the time being. It excludes the old version of scalariform and manually uses the new one:

addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "0.7.0" excludeAll(
  ExclusionRule(organization = "com.danieltrinh")))
libraryDependencies += "org.scalariform" %% "scalariform" % "0.1.7"

@nlochschmidt
Copy link

Any plans on releasing a 0.7.1?

@SethTisue
Copy link
Contributor

thanks @ahirreddy for the workaround, this is really helpful

@fernandomora
Copy link

Could a 0.7.1 version upgraded with scalariform 0.1.7 be released?
All builds are failing after upgrading to sbt 0.13.9

@SethTisue SethTisue mentioned this issue Oct 29, 2015
Merged
@SethTisue SethTisue mentioned this issue Nov 17, 2015
Closed
@SethTisue SethTisue mentioned this issue Nov 30, 2015
Merged
@JoshRosen JoshRosen mentioned this issue Dec 2, 2015
Closed
asfgit pushed a commit to apache/spark that referenced this issue Dec 5, 2015
@JoshRosen @rxin
[SPARK-12112][BUILD] Upgrade to SBT 0.13.9
b7204e1 
We should upgrade to SBT 0.13.9, since this is a requirement in order to use SBT's new Maven-style resolution features (which will be done in a separate patch, because it's blocked by some binary compatibility issues in the POM reader plugin).

I also upgraded Scalastyle to version 0.8.0, which was necessary in order to fix a Scala 2.10.5 compatibility issue (see scalastyle/scalastyle#156). The newer Scalastyle is slightly stricter about whitespace surrounding tokens, so I fixed the new style violations.

Author: Josh Rosen <joshrosen@databricks.com>

Closes #10112 from JoshRosen/upgrade-to-sbt-0.13.9.
@markschaake markschaake mentioned this issue Dec 17, 2015
Closed
smarter added a commit to smarter/dotty that referenced this issue Feb 24, 2016
@smarter
Upgrade sbt to 0.13.11 and scalastyle-sbt-plugin to 0.8.0
920c70a 
Upgrading scalastyle-sbt-plugin allows us to remove the workaround for
scalastyle/scalastyle#156
smarter added a commit to dotty-staging/dotty that referenced this issue Feb 28, 2016
@smarter
Upgrade sbt to 0.13.11 and scalastyle-sbt-plugin to 0.8.0
5213a0a 
Upgrading sbt will allow us to experiment with bootstrapping
using sbt since 0.13.11 is the first release that supports this (see
https://github.com/smarter/dotty-bridge).

Upgrading scalastyle-sbt-plugin allows us to remove the workaround for
scalastyle/scalastyle#156
smarter added a commit to dotty-staging/dotty that referenced this issue Feb 28, 2016
@smarter
Upgrade sbt to 0.13.11 and scalastyle-sbt-plugin to 0.8.0
327960e 
Upgrading sbt will allow us to experiment with bootstrapping
using sbt since 0.13.11 is the first release that supports building
with dotty (see https://github.com/smarter/dotty-bridge).

Upgrading scalastyle-sbt-plugin allows us to remove the workaround for
scalastyle/scalastyle#156
@smarter smarter mentioned this issue Feb 28, 2016
Merged
CalumMcCall pushed a commit to advancedtelematic/ota-plus-server that referenced this issue Aug 4, 2016
Add device created event to web api
d2f9cc6 
 - PRO-941
 - Bump scalastyle version to get around bug:
   scalastyle/scalastyle#156

blah
CalumMcCall pushed a commit to advancedtelematic/ota-plus-server that referenced this issue Aug 5, 2016
Add device created event to web api
982e622 
 - PRO-941
 - Bump scalastyle version to get around bug:
   scalastyle/scalastyle#156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to scalariform 0.1.7 kciesielski/scalastyle
5 participants
@ahirreddy @SethTisue @nlochschmidt @ajozwik @fernandomora