Magic Number

[fatlazycat]

I can see it's only partially implemented but how would currently comply ?

I'd expect

object Something {
val someVal = 50
}

to pass

[matthewfarwell]

Sorry for the late reply. That's the reason it's only partially implemented. It detects the fact that a magic number is used, but can't tell the context, so there isn't a way to comply.

The eventual rule will be something like you say. If the magic number is part of an expression which is directly assigned to a val, whether in an object, class or trait, then you won't get an error.

It's on my list of things to do, but if you wanted to submit a patch, that would be welcome :-)

[fatlazycat]

Yeah will give it a go :)

[matthewfarwell]

I still haven't implemented this yet, but this is what I'm planning:

A magic number is a number that is not -1,0,1,2 (configurable) which appears. The rule will not raise an warning if the value is directly assigned to a val in an object, such as:

object Foo {
val bar = 5
}

and optionally, the same thing but in a class:

class Foo {
val bar = 5
}

If the number is not a direct assignment, then this will always raise a warning:

object Foo {
val f = new Foo(5) // always raise an error
}

This is because we can't guarantee that Foo is immutable.