-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncFunSuite and StepwiseNestedSuiteExecution do not work together #2181
Comments
The second bug is probably related to item 2 in this comment. |
@jespermbyskov Your first fix does look valid to me, I'll try and look into your detailed example code. Cheers. |
@jespermbyskov Based on the code you posted I have submitted the following PR: Would you mind to verify if it will fix the problem that you are facing? Cheers. |
@cheeseng I tried running my tests with the changes in the PR, and the test succeeds, also when not running with the |
I updated to ScalaTest 3.2.15 and that fixes my problem, so I think that this issue can be closed. |
I have a test suite that extends
AsyncFunSuite
. I would like to parallelise it, but I have some tests that need to run sequentially, and only after all parallel tests have run.Now, I tried to split the suite in two and added a parent suite extending
StepwiseNestedSuiteExecution
with two nestedAsyncFunSuite
s, the first of which extendsParallelTestExecution
, see example code below. If I run this, either with or without the-P
option, all the parallel tests are started, but right after the sequential ones are started, before the parallel once have finished. I believe that this is a bug in thecallExecuteOnSuite
method inStepwiseNestedSuiteExecution
, since it always returns aSucceededStatus
right after having invokedrun
on the nested suite, instead of returning the status returned by that call. If I create a copy ofStepwiseNestedSuiteExecution
where I replace the lineswith
then it seems to work. I have not created a PR for this, as I do not know the code well enough to know, if this has unintended effects.
Even with the above changes to
StepwiseNestedSuiteExecution
, if I run the test without the-P
option, I get the following error:which seems to be caused by no
Distributor
being sent to therunTests
method inParallelTestExecution
. I believe, that this is another bug.Example code:
The text was updated successfully, but these errors were encountered: