[3.2] Scala-JS UUID Fix #2118
Merged
[3.2] Scala-JS UUID Fix #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestSortingReporter` itself is `private[scalatest]`, so we can make that change. It makes it clear that they are not used elsewhere in `scalatest`, and that we can therefore change them.
…tingReporter. The UUIDs are only used as an in-memory identifier for `Slot`s. It is more efficient and more reliable to use an object identity instead, for that purpose. This removes the dependency on `UUID.randomUUID()`, which unblocks using ScalaTest with Scala.js >= 1.10.0. See GHSA-j2f9-w8wh-9ww4 and scala-js/scala-js#4657 for the reason why `randomUUID()` fails to link by default in recent Scala.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picked commits from #2117
which drop the use of UUID as it is an issue in the new scala-js 1.10 release. The alternative looks good and worked in test, binary compat wise should be fine as TestSortingReporter is a internal class that is not intended for third-party use.
Note after this is merged into 3.2.x-new branch we'll pull changes in 3.2 into main, which should automatically merge and close @sjrd 's PR #2117 .
Thanks.