Fix prettifier not being used for property check #2173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in PR #2155 I fixed the
Prettifier
so that it works on case classes however I noticed that its still not being applied even when usingimplicit val prettifier: Prettifier = Prettifier.truncateAt(SizeLimit(10))
, i.e.This keeps on going for ages, i.e. its not being truncated. This is when using scalatestplus-scalacheck with property based tests. After going through the code I think that I found the culprit is was in
decorateStringToValue
, one of them uses a prettifier but the other completely ignores. Not sure if this is an oversight or if I am looking in the wrong places.Would also like to add a test for this to verify this but not sure where is the appropriate place to put this.
References: #2174