Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conductors Adjustment #2284

Merged
merged 1 commit into from Sep 27, 2023

Conversation

cheeseng
Copy link
Contributor

Try to catch UnsupportedOperationException when calling Thread's stop, and try to call method interrupt when that happens as next attempt to stop the running thread. This unblocks the ConductorSuite when runs using JDK 21.

…, and try to call method interrupt when that happens as next attempt to stop the running thread. This unblocks the ConductorSuite when runs using JDK 21.
@cla-bot cla-bot bot added the cla-signed label Sep 24, 2023
Copy link
Contributor

@bvenners bvenners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Java folks are probably trying to tell us to not call stop anymore, but let's keep this working. Conductor was always iffy, because it is guaranteed to work according to the JMM.

@cheeseng cheeseng merged commit f1e2005 into scalatest:3.2.x-new Sep 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants