Scala 2 Macro Fix for isEmpty #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for your fix, I will build a snapshot to test it later |
LuciferYang
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
+1, LGTM
The test results are as expected after local packaging, thanks @cheeseng
srowen
pushed a commit
to apache/spark
that referenced
this pull request
Oct 22, 2023
…IB][K8S][YARN][SHELL][PYTHON][R][AVRO][UI][EXAMPLES] Fix the compilation warning "Auto-application to `()` is deprecated" and turn it into a compilation error ### What changes were proposed in this pull request? This PR mainly does two things: 1. Clean up all compilation warnings related to "Auto-application to () is deprecated". 2. Change the compilation options to convert this compilation warning into a compilation error. Additionally, due to an issue with scalatest(scalatest/scalatest#2297), there are some false positives. Therefore, this PR has added the corresponding rules to suppress them, and left the corresponding TODO(SPARK-45615). We can clean up these rules after scalatest fixes this issue(scalatest/scalatest#2298). ### Why are the changes needed? 1. Clean up the deprecated usage methods. 2. As this compilation warning will become a compilation error in Scala 3, to ensure it does not occur again, this PR also converts it into a compilation error in Scala 2.13. For example, for the following code: ```scala class Foo { def isEmpty(): Boolean = true } val foo = new Foo val ret = foo.isEmpty ``` In Scala 2.13: ``` Welcome to Scala 2.13.12 (OpenJDK 64-Bit Server VM, Java 17.0.8). Type in expressions for evaluation. Or try :help. scala> class Foo { | def isEmpty(): Boolean = true | } class Foo scala> val foo = new Foo | val foo: Foo = Foo7e15f4d4 scala> val ret = foo.isEmpty ^ warning: Auto-application to `()` is deprecated. Supply the empty argument list `()` explicitly to invoke method isEmpty, or remove the empty argument list from its definition (Java-defined methods are exempt). In Scala 3, an unapplied method like this will be eta-expanded into a function. [quickfixable] val ret: Boolean = true ``` In Scala 3: ``` Welcome to Scala 3.3.1 (17.0.8, Java OpenJDK 64-Bit Server VM). Type in expressions for evaluation. Or try :help. scala> class Foo { | def isEmpty(): Boolean = true | } // defined class Foo scala> val foo = new Foo val foo: Foo = Foo150d6eaf scala> val ret = foo.isEmpty -- [E100] Syntax Error: -------------------------------------------------------- 1 |val ret = foo.isEmpty | ^^^^^^^^^^^ | method isEmpty in class Foo must be called with () argument |----------------------------------------------------------------------------- | Explanation (enabled by `-explain`) |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | Previously an empty argument list () was implicitly inserted when calling a nullary method without arguments. E.g. | | def next(): T = ... | |next // is expanded to next() | | In Dotty, this idiom is an error. The application syntax has to follow exactly the parameter syntax. | Excluded from this rule are methods that are defined in Java or that override methods defined in Java. ----------------------------------------------------------------------------- 1 error found ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #43472 from LuciferYang/SPARK-45610. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Sean Owen <srowen@gmail.com>
bvenners
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unexpected warning in Scala 2 macro for assert(foo.isEmpty()) as reported in #2297 .