Safe PrivateMethodTester #2301
Open
Safe PrivateMethodTester #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, which in previous version just use Any, supported up to 6 arguments in this commit.
bvenners
reviewed
May 24, 2024
| */ | ||
| def apply(args: Any*) = new Invocation[T](methodName, args: _*) | ||
| def apply() = new Invocation0[T](methodName) | ||
| } |
There was a problem hiding this comment.
I think we should leave PrivateMethod alone so that no code breaks. We can decide to deprecate it, but that would give folks time to change to PrivateMethodN. Or we could not deprecate it and just let people choose. So please take PrivateMethod and plain old Invocation back to the way it was, then probably add a PrivateMethod0 trait that would use the Invocation0 object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safer PrivateMethodTester, with typed arguments vs the existing one that's use only Any.
Related ticket that complained about the problem:
#2300