Runner Discovered Suites #2319
Merged
Runner Discovered Suites #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neko-kai Can you test out this PR to see if it adequately addresses your needs? |
neko-kai
added a commit
to 7mind/izumi
that referenced
this pull request
May 24, 2024
…e all custom discovery
|
@bvenners Yes, I just tested – it fully solves the problem! (7mind/izumi#2120) |
…ature-runner-discovered-suites
|
@bvenners I resolved the conflicts, I can merge this in after your review. Thanks. |
bvenners
reviewed
Jun 7, 2024
| (if (wildcard.isEmpty && membersOnly.isEmpty) taskDefs else (filterWildcard(wildcard, taskDefs) ++ filterMembersOnly(membersOnly, taskDefs)).distinct).map(createTask) | ||
| val tasks = (if (wildcard.isEmpty && membersOnly.isEmpty) taskDefs else (filterWildcard(wildcard, taskDefs) ++ filterMembersOnly(membersOnly, taskDefs)).distinct).map(createTask) | ||
|
|
||
| //runnerInstance().internalDiscoveredSuites.set(Some(discoveredSuites)) |
bvenners
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose discovered suites through Runner's discoveredSuites.