Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaping String Differ #2323

Closed
wants to merge 53 commits into from
Closed

Escaping String Differ #2323

wants to merge 53 commits into from

Conversation

cheeseng
Copy link
Contributor

Enhanced StringDiffer to display escaped character in String when failing.

@cheeseng
First step in displaying escaped string in analysis when either LHS o…
2c82666 
…r RHS contains String with suspicious characters.
@cheeseng
Changed StringDiffer to escape char in the analysis.
ad34a73
@cheeseng
Added NotContainingStringMatchResult.
8927d52
@cheeseng
Added limit for EscapingStringDiffer according to the passed Prettifi…
c10c9d7 
…er's limit
@cheeseng
Added more places to support the escaping string analysis.
a847133
@cheeseng
Refactored to eliminate duplicated code for Iterable and Array, adjus…
8d83ba0 
…ted error messages.
@cheeseng
Changed to use resource bundle for messages in EscapingStringDiffer.
49a8a89
@cheeseng
Refactored EqualMatchResult, NotEqualMatchResult, ContainingStringMat…
b32eb74 
…chResult and NotContainingStringMatchResult as sub classes of MatchResultWithAnalysis.
@cheeseng
Added first batch of unit tests for escaping string analysis.
157bdb3
@cheeseng
Got first step should contain to work with escaping string differ.
1edb900
@cheeseng
Got more unit tests to pass.
8eb416c
@cheeseng
Changed the implementation of Prettifier's withEscapingDiffer to use …
df155b9 
…the passed prettifier for left and right diff, but use escaping differ only for analysis.
@cheeseng
Added unit tests to ShouldContainKeySpec.scala, and the support for j…
45a4999 
…ava.util.Map for escaping Differ analysis.
@cheeseng
Added escaping string analysis support for 'should contain value' syn…
64f3992 
…tax.
@cheeseng
Got escaping string analysis to work with allOf matcher.
24225ea
@cheeseng
Got escaping string analysis to work with allElementsOf matcher.
2565870
@cheeseng
Got Every to work with escaping string analysis for contain, contain …
2d27dc9 
…allOf and contain allElementsOf matcher.
@cheeseng
Got escaping string analysis to work with atLeastOneOf matcher.
da89678
@cheeseng
Fixed unit tests name.
a41d40f
@cheeseng
Got escaping string analysis to work with atLeastOneElementOf matcher.
f47226e
@cheeseng
Got escaping string analysis to work with atMostOneOf matcher.
aa20160
@cheeseng
Got escaping string analysis to work with atMostOneElementOf matcher.
cd49c94
@cheeseng
Got escaping string analysis to work with inOrder matcher.
821f3e6
@cheeseng
Got escaping string analysis to work with inOrderElementsOf matcher.
3b516d2
@cheeseng
Added the missing support of xs should (contain xxxx yy) syntax for p…
ed4dc8b 
…reviously supported syntax for escaping string analysis.
@cheeseng
Got escaping string analysis to work with noneOf matcher.
99dd84c
@cheeseng
Got escaping string analysis to work with noElementsOf matcher.
eaf1d42
@cheeseng
Got escaping string analysis to work with oneOf matcher.
a8e9a18
@cheeseng
Got escaping string analysis to work with oneElementOf matcher.
d9c3202
@cheeseng
Got escaping string analysis to work with only matcher.
2c96e3d
@cla-bot cla-bot bot added the cla-signed label Apr 29, 2024
@cheeseng cheeseng mentioned this pull request Apr 29, 2024
Closed
@cheeseng
Try to change setup-java@v3 to @v4.
fe7bf78
@cheeseng
Updated actions/checkout@v2 to @v4 also.
97ff4d1
@cheeseng
Updated to use ubuntu-latest, replacing macos-latest.
50ce8f1
@cheeseng
Got gentests to compile, but tests are still failing.
8d4e567
@cheeseng
Fixed part of test failures in gentests.
7a55ad3
@cheeseng
Second batch of failing tests fixed in gentests.
2f5a1af
@cheeseng
Another batch of failing tests fix in gentests.
9455437
@cheeseng
More failing tests fixed in gentests.
2f90262
@cheeseng
More failing tests fixed in gentests.
e3d032a
@cheeseng
More failing tests fixed in gentests.
88ea559
@cheeseng
More failing tests fixed in gentests.
b5ed246
@cheeseng
More failing tests fixed in gentests.
670825a
@cheeseng
More failing tests fixed in gentests.
f45304d
@cheeseng
More failing tests fixed in gentests.
d86d4a3
@cheeseng
More failing tests fixed in gentests.
5cb29c3
@cheeseng
More failing tests fixed in gentests.
836c819
@cheeseng
More failing tests fixed in gentests.
c91bebb
@cheeseng
More failing tests fixed in gentests, one more last failing suite to go.
5711dcc
@cheeseng
Got all gentests to pass!
889ba15
bvenners
bvenners approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@bvenners bvenners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to merge into main branch, because it may have breaking changes with respect to EqualMatchResult.

@cheeseng
Copy link
Contributor Author

Closing in favor for #2327 .

@cheeseng cheeseng closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvenners bvenners bvenners approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cheeseng @bvenners