Replace maxDiscarded with maxDiscardedFactor, to make more consistent with ScalaCheck #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flicken
force-pushed
the
max-discarded-ratio
branch
2 times, most recently
from
e33488f
to
6fd2084
Compare
flicken
changed the title
flicken
changed the title
flicken
force-pushed
the
max-discarded-ratio
branch
from
6fd2084
to
70c9e90
Compare
flicken
force-pushed
the
max-discarded-ratio
branch
2 times, most recently
from
ff9a1f4
to
a80be7f
Compare
flicken
force-pushed
the
max-discarded-ratio
branch
2 times, most recently
from
b52e2f9
to
2de10b6
Compare
flicken
force-pushed
the
max-discarded-ratio
branch
8 times, most recently
from
5bded57
to
b1278e8
Compare
flicken
force-pushed
the
max-discarded-ratio
branch
from
d185c01
to
5904796
Compare
…ertyCheckConfig. (Uses PosX.from factory methods, because "you cannot use macro implementations in the same compilation run that defines them". If scalactic were in a separate compile, this would go away.)
Ensure all references to PropertyCheckConfig -> PropertyCheckConfiguration and update documentation. Add SizeRange and sizeRange, deprecating MaxSize and maxSize. Use private[scalatest] fields for legacy param values. Separate out PropertyCheckConfigurationHelperSuite.
TODO: Try to find a smoother upgrade path---compile errors would likely not indicate to a user that this change was required. Example error message:
[error] /Users/broberts/Documents/workspace/scalatest/gentests/GenGen/target/scala-2.11/src_managed/test/scala/gengen/GeneratorDrivenPropertyChecksMixinSuite.scala:702: could not find implicit value for parameter config: GeneratorDrivenPropertyChecksMixinSuite.this.PropertyCheckConfiguration
[error] forAll { (a: String) =>
[error] ^
…> PropertyCheckConfiguration change. See ConfigImplicitOverrideInClassTest.
…iguration and deprecated PropertyCheckConfig. This allows more seamless upgrades. See fixed ConfigImplicitOverrideInClassTest for an example where this is necessary.
flicken
force-pushed
the
max-discarded-ratio
branch
from
5904796
to
368f308
Compare
… to scalactic-macros project being separated out in scalatest#457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScalaCheck changed maxDiscarded to maxDiscardRatio. ScalaTest should follow, see: typelevel/scalacheck#11