Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockito 5 #33

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Mockito 5 #33

merged 3 commits into from
Dec 18, 2023

Conversation

cheeseng
Copy link
Contributor

@cheeseng cheeseng commented Oct 14, 2023

Updated to use mockito 5.8.0, and added a note in README.md about the requirement for jdk11 for mockito 5.

@LuciferYang
Copy link

Need to switch to installing Java 11.

@cheeseng
Copy link
Contributor Author

Need to switch to installing Java 11.

Yup, you're right, CI passed now, thanks.

@DieBauer
Copy link

Any plans on this? The official site already advertises this, but the artifact doesn't exist:
https://www.scalatest.org/plus/mockito
libraryDependencies += "org.scalatestplus" %% "mockito-5-6" % "3.2.17.0" % "test"

@cheeseng
Copy link
Contributor Author

@DieBauer I am sorry we overlooked this and I think the previously staged artifacts for mockito 5.6 was dropped automatically, I have re-staged with latest mockito 5.8 and hopefully @bvenners shall release it soon!

@DieBauer
Copy link

Thanks for the update, and effort :)

@LuciferYang
Copy link

It looks like need to update the PR description. The current PR description is still Updated to use mockito 5.6.0.

@cheeseng
Copy link
Contributor Author

@LuciferYang Thanks for the kind reminder.

And the good news is @bvenners has just released the artifacts!

@cheeseng cheeseng merged commit 5b82a9a into main Dec 18, 2023
3 checks passed
@Martomate
Copy link

Hello! Just so you know, the website still mentions 5.6 instead of 5.8 (https://www.scalatest.org/plus/mockito). Would be nice if it was updated.

@cheeseng
Copy link
Contributor Author

@Martomate Thanks for the reminder, I have submitted the following PR for it:

scalatest/scalatest-website#235

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants