500 error 500.scaml template not having correct content-type

[octplane]

Because there is no content type set by ScalateSupport#handleError, it is inferred at a later stage by Scalatra as text/plain.

I'd suggest that ScalateSupport#handleError set the content-type to text/html, a reasonable default.

[rossabaker]

ScalateSupport#handleError first calls ScalatraKernel#handleError to let the error block run. If that error block returns a value, then that result will be rendered just like a typical action, with the same content type inference. If that error block rethrows the exception, then it is rendered with the Scalate error console as text/html.

Do you have a custom error block? If so, what is it returning? Could you set the content type there?

[octplane]

I have no custom error block. Maybe this is where I should do something ?

[rossabaker]

The default error block just rethrows the exception, which should result in the Scalate console being displayed as text/html. This works for me. If you can post a minimal application with the problem, then I can try to figure out how yours is different.

[octplane]

https://github.com/octplane/scalatra-issue-47

./sbt
update
jetty

and go to http://localhost:8080/500/

The 500 page is sent as text/plain.

[casualjim]

nice one... this bug should be fixed on the akka-integration branch... we might be able to put that in master in the next week or so

[rossabaker]

Thank you for the test project -- that is a big help!

The reason I couldn't reproduce this was that I was using the 500.scaml out of the Scalate jar. That version explicitly sets the content type. You overrode that file without setting the content type. I just explicitly set it in ScalateSupport.renderErrorPage, so error pages will now default to text/html.

Until the next release, the workaround is to add this to your template:

- response.setContentType("text/html")

[octplane]

Ha ! So there is a way to do that directly in the template. That's cool. (my first goal was to have a 500 in json... :)). Thanks for the supports guys !

[octplane]

I suppose I can destroy the test project now ?