This repository has been archived by the owner on Nov 28, 2019. It is now read-only.
Update ZIO to 1.0-RC1 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a lot =) |
|
Yes, it is ;). My goal was to keep the original meaning using the new primitives. And the missing thing is |
jczuchnowski
force-pushed
the
scalaz-zio-1.0-rc1
branch
from
ce12213
to
cb8d7cd
Compare
|
I went with the solution suggested by @LGLO on gitter channel. |
LGLO
reviewed
Mar 8, 2019
| } yield c1 == c2 | ||
| assert(unsafeRun(testProgram)) | ||
| }, { | ||
| // <<<<<<< HEAD |
There was a problem hiding this comment.
cleanup pls
Why is it removed / commented out?
jczuchnowski
force-pushed
the
scalaz-zio-1.0-rc1
branch
from
e4d0e47
to
ccd29ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could use help with rewriting
AsynchronousChannel.wrap.