Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible memory leak when using TypeApi.<:< #51

Closed
zella opened this issue May 31, 2021 · 1 comment
Closed

Possible memory leak when using TypeApi.<:< #51

zella opened this issue May 31, 2021 · 1 comment

Comments

@zella
Copy link

zella commented May 31, 2021

According scala/bug#8302 TypeApi.<:< invocations should be wrapped into JavaUniverse.undoLog.undo()

This api used in injectSymbol method.
@dave-handy
Copy link
Member

Thanks! This looks fairly straightforward. There are plenty of uses of <:< in the scaldi core module as well, so I'll have to take a fairly broad look at this.

dave-handy added a commit that referenced this issue Jul 27, 2021
@dave-handy
Merge pull request #60 from scaldi/undolog
9bac57d 
Wrap <:< check in undolog fixes #51. Also minor formatting updates, n…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zella @dave-handy