Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transport to write in batches to increase throughput #199

Closed
ronenhamias opened this issue Nov 15, 2017 · 0 comments
Closed

Improve transport to write in batches to increase throughput #199

ronenhamias opened this issue Nov 15, 2017 · 0 comments

Comments

@ronenhamias
Copy link
Member

ronenhamias commented Nov 15, 2017

currently transport sends messages and write and flush on each request

private void send(Channel channel, Message message, CompletableFuture<Void> promise) {
    if (promise == COMPLETED_PROMISE) {
      channel.writeAndFlush(message, channel.voidPromise());
    } else {
      composeFutures(channel.writeAndFlush(message), promise);
    }
  }

write and flush create a syscall on each message reducing throughput an alternative approach might be by write in batches so flush will be done periodical on favor with the right balance between latency and throughput.

artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare release v2.0.23
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
artem-v pushed a commit that referenced this issue Nov 6, 2018
Prepare release [skip ci] prepare for next development iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant