Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Updated To Latest OBS Plugin Template #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ashmanix
Copy link

Reason For This Update

I came across this plugin on the OBS plugin website and needed to use it on my MacOS device. I noticed that there were only downloadable files for Windows and so I spent a while trying to build the code locally for my Mac. I've used this plugin a lot when making videos for YouTube and appreciate the work you put into it!

I recently looked at the latest OBS Plugin Template and I noticed that they are using GitHub workflows to automatically build versions of a plugin for all operating systems! I thought this would be handy for me so I forked this repo and attempted to merge the template code into this repo. The result is what I've for here for the pull request.

Automatic Building Of Plugin

To create the plugin files for all operating systems all you need to do is create a GitHub tag on a branch and push it to the repo. The workflows will automatically do code formatting checks and will then build the plugin for all operating systems and attach the built files as a release using the tag name.

Notes

  • One issue I've had with this is that the format check is very sensitive and the whole process will fail if the format check fails! I had to make some minor changes to the source code to get the format check to pass.
  • I've tried to set the plugin details to match the details you had originally but I might have made a mistake. I've also set the version to 1.3.0 to be 1 minor version above what you currently have. Not sure if this was correct to do.

Hopefully you find this pull request beneficial!

Ashmanix

@ashmanix ashmanix mentioned this pull request Oct 8, 2022
@scaledteam
Copy link
Owner

Sorry, i was really busy IRL when you sent this pull request. Thank you for you work, but this scripts makes this plugin much more complicated. Maybe i can post a link to your project as mac os version?

@ashmanix
Copy link
Author

ashmanix commented Oct 8, 2022

The scripts are complicated and I don't understand how they work either but they seem to work in building for all operating systems which is handy.

If you want to link a post to my project thats cool 👍

@scaledteam
Copy link
Owner

Okay, i will post a link to your version here and in OBS forum. Thank you for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants