Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp on combiner log #284

Closed
aitmlouk opened this issue Sep 24, 2021 · 3 comments · Fixed by #296
Closed

Timestamp on combiner log #284

aitmlouk opened this issue Sep 24, 2021 · 3 comments · Fixed by #296
Assignees

Comments

@aitmlouk
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Why not adding a Timestamp to the combiner log like reducer, then at least it will help to track errors for long training

Describe the solution you'd like
A clear and concise description of what you want to happen.
Instead of having this:
combiner_1 | COMBINER(FEDn_Combiner_addi):0 COMBINER: waiting for model updates: 0 of 4 completed.

it's better to have this:
combiner_1 | COMBINER(FEDn_Combiner_addi): 09/24/2021 09:38:58 AM 0 COMBINER: waiting for model updates: 0 of 4 completed.

Describe any drawbacks (if any)
None

Contact Details
An e-mail address in case we need to contact you for further details regarding this request.

@ahellander
Copy link
Member

ahellander commented Sep 24, 2021 via email

@aitmlouk
Copy link
Contributor Author

We have this on reducer and client-log but not on combiners

@ahellander ahellander assigned aitmlouk and Wrede and unassigned aitmlouk Oct 6, 2021
@ahellander ahellander linked a pull request Oct 11, 2021 that will close this issue
15 tasks
@Wrede Wrede closed this as completed Oct 12, 2021
@Wrede
Copy link
Collaborator

Wrede commented Oct 12, 2021

Merged in #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants