Feature/SK-505 | Flush model update queues at new session + Buffer size config #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrede
changed the title
Wrede
requested changes
Aug 1, 2023
added 3 commits
August 1, 2023 16:41
Wrede
approved these changes
Aug 2, 2023
Wrede
added a commit
that referenced
this pull request
Oct 25, 2023
…ze config (#476) * model update queues gets flushed in the beginning of a new session * Changed confusing log message * buffer_size now configurable, solves sk-520 * exclude isort for protobuf files * Deleted commented code * Added response status message --------- Co-authored-by: Andreas Hellander <andreas.hellander@gmail.com> Co-authored-by: Fredrik Wrede <fredrik@scaleoutsystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the global round logic such that the combiner aggregation queues are flushed at the beginning of every new session. Make 'buffer size' configurable.
Resolves