Feature/SK-634 | Add logging to controller #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrede
requested changes
Jan 30, 2024
| @@ -80,14 +80,14 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 70, | |||
| @@ -54,8 +54,7 @@ def push_round_config(self, round_config): | |||
| round_config['_job_id'] = str(uuid.uuid4()) | |||
| self.round_configs.put(round_config) | |||
| except Exception: | |||
| logger.warning( | |||
| "ROUNDCONTROL: Failed to push round config.") | |||
| logger.warning("Failed to push round config.") | |||
There was a problem hiding this comment.
should be logger.error since it contains "raise"
| @@ -220,12 +217,11 @@ def stage_model(self, model_id, timeout_retry=3, retry=2): | |||
| if model: | |||
| break | |||
| except Exception: | |||
| logger.info("ROUNDCONTROL: Could not fetch model from storage backend, retrying.") | |||
| logger.info("Could not fetch model from storage backend, retrying.") | |||
| time.sleep(timeout_retry) | ||
| tries += 1 | ||
| if tries > retry: | ||
| logger.info( | ||
| "ROUNDCONTROL: Failed to stage model {} from storage backend!".format(model_id)) | ||
| logger.info("Failed to stage model {} from storage backend!".format(model_id)) |
| return | ||
|
|
||
| if not self.statestore.get_latest_model(): | ||
| print("No model in model chain, please provide a seed model!") | ||
| logger.info("No model in model chain, please provide a seed model!") |
| return | ||
| self.__state = ReducerState.instructing | ||
|
|
||
| # Check for a model chain | ||
| if not self.statestore.latest_model(): | ||
| print("No model in model chain, please seed the alliance!") | ||
| logger.info("No model in model chain, please seed the alliance!") |
There was a problem hiding this comment.
logger.warning, also "alliance"?
| @@ -399,7 +361,7 @@ def inference_round(self, config): | |||
|
|
|||
| # Check for at least one combiner in statestore | |||
| if len(self.network.get_combiners()) < 1: | |||
| print("REDUCER: No combiners connected!") | |||
| logger.warning("REDUCER: No combiners connected!") | |||
| "REDUCER CONTROL: Storage backend not configured, waiting...", | ||
| flush=True, | ||
| ) | ||
| logger.info("Storage backend not configured, waiting...") |
Wrede
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates controller to use logging module.
Closed SK-634