Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SK-707 | Add config support to flower adapter #570

Merged
merged 11 commits into from
Apr 12, 2024

Conversation

viktorvaladi
Copy link
Contributor

Adds built-in config support to the flower adapter, for flower clients which use that.

Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See comment about FEDn-version.

@Wrede
Copy link
Collaborator

Wrede commented Apr 12, 2024

I suggest that you also replace the build scripts with "fedn package create" and "fedn run build". Maybe remove ENTRTPOINT_OPS since they are confusing.

examples/flower-client/README.rst Outdated Show resolved Hide resolved
@viktorvaladi viktorvaladi merged commit c5ee522 into master Apr 12, 2024
7 checks passed
@viktorvaladi viktorvaladi deleted the feature/SK-707 branch April 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants