Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/SK-793 | Fix package extract and dispatch folder #597

Merged
merged 6 commits into from
May 7, 2024
Merged

Conversation

Wrede
Copy link
Collaborator

@Wrede Wrede commented May 6, 2024

on package extract (untar) tarball will now extract to default folder "package" from client CWD. The directory can be chnaged using FEDN_PACKAGE_EXTRACT_DIR environment var.

When a package is extracted FEDn searches for "fedn.yaml" in the root and child folders in the extracted folder. The path of fedn.yaml is saved and will be the "run path" for the dispatcher. In other words relative path in entry_points will be realative "run path"

@Wrede Wrede requested a review from ahellander May 6, 2024 15:01
Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Only question is what happens if a user already has a folder called "package" in their project structure (unlikely, but could happen).

@Wrede
Copy link
Collaborator Author

Wrede commented May 7, 2024

fedn will then not create the folder since it already exist, the tarball will be extracted into the folder, any conflicts will be overwritten, any files that already existed will still be there.

@Wrede Wrede merged commit 505a5ce into master May 7, 2024
11 checks passed
@Wrede Wrede deleted the bug/SK-793 branch May 7, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants