Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add timeout configuration for all steps #49

Merged
merged 3 commits into from
Jul 25, 2022
Merged

feat: add timeout configuration for all steps #49

merged 3 commits into from
Jul 25, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jul 20, 2022

No description provided.

@yfodil yfodil requested a review from a team as a code owner July 20, 2022 15:58
@yfodil yfodil requested review from Vinzius and removed request for a team July 20, 2022 15:58
@yfodil yfodil marked this pull request as draft July 20, 2022 15:58
remyleone
remyleone reviewed Jul 20, 2022
View reviewed changes
builder/scaleway/config.go Outdated Show resolved Hide resolved
builder/scaleway/config.go Outdated Show resolved Hide resolved
docs-partials/builder/scaleway/Config-not-required.mdx Outdated Show resolved Hide resolved
builder/scaleway/step_create_image.go Outdated Show resolved Hide resolved
builder/scaleway/step_snapshot.go Outdated Show resolved Hide resolved
@yfodil yfodil removed the request for review from Vinzius July 21, 2022 13:58
remyleone
remyleone requested changes Jul 21, 2022
View reviewed changes
docs-partials/builder/scaleway/Config-not-required.mdx Outdated Show resolved Hide resolved
docs-partials/builder/scaleway/Config-not-required.mdx Outdated Show resolved Hide resolved
builder/scaleway/step_create_image.go Outdated Show resolved Hide resolved
builder/scaleway/config.go Outdated Show resolved Hide resolved
builder/scaleway/step_snapshot.go Outdated Show resolved Hide resolved
@yfodil yfodil marked this pull request as ready for review July 22, 2022 12:53
@remyleone remyleone changed the title fix: add timeouts feat: add timeout configuration for all steps Jul 22, 2022
@remyleone remyleone merged commit 0e6a529 into scaleway:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yfodil @remyleone