feat(fip): add support for ipv6 creation (#2260)

Co-authored-by: Rémy Léone <rleone@scaleway.com>
scaleway · Apr 14, 2022 · 7f5cd97 · 7f5cd97
1 parent e312a5e
commit 7f5cd97
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 3 deletions.
diff --git a/cmd/scw/testdata/test-all-usage-fip-ip-create-usage.golden b/cmd/scw/testdata/test-all-usage-fip-ip-create-usage.golden
@@ -11,6 +11,7 @@ ARGS:
   [tags.{index}]    Tags to associate to the Flexible IP
   [server-id]       Server ID on which to attach the created Flexible IP
   [reverse]         Reverse DNS value
+  [is-ipv6]         If true, creates a Flexible IP with an ipv6 address
   [zone=fr-par-1]   Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1)
 
 FLAGS:

diff --git a/docs/commands/fip.md b/docs/commands/fip.md
@@ -64,6 +64,7 @@ scw fip ip create [arg=value ...]
 | tags.{index} |  | Tags to associate to the Flexible IP |
 | server-id |  | Server ID on which to attach the created Flexible IP |
 | reverse |  | Reverse DNS value |
+| is-ipv6 |  | If true, creates a Flexible IP with an ipv6 address |
 | zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1` | Zone to target. If none is passed will use default zone from the config |
 
 

diff --git a/go.mod b/go.mod
@@ -17,7 +17,7 @@ require (
 	github.com/kubernetes-client/go-base v0.0.0-20190205182333-3d0e39759d98
 	github.com/mattn/go-colorable v0.1.12
 	github.com/mattn/go-isatty v0.0.14
-	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220412084709-d53c9b6a9869
+	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220413124200-87ec17340712
 	github.com/spf13/cobra v1.4.0
 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.7.1

diff --git a/go.sum b/go.sum
@@ -57,8 +57,8 @@ github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINE
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220412084709-d53c9b6a9869 h1:6dr1njWPdA/51l1/YVrgu921SuRSRPr1WzeKDQUktH0=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220412084709-d53c9b6a9869/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220413124200-87ec17340712 h1:MOkU+rQ1ZIIqYAjCUwd1qaOapaECgic6kZjuT+iK2/Y=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220413124200-87ec17340712/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
 github.com/sergi/go-diff v1.2.0 h1:XU+rvMAioB0UC3q1MFrIQy4Vo5/4VsRDQQXHsEya6xQ=
 github.com/sergi/go-diff v1.2.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
 github.com/spf13/cobra v1.4.0 h1:y+wJpx64xcgO1V+RcnwW0LEHxTKRi2ZDPSBjWnrg88Q=

diff --git a/internal/namespaces/flexibleip/v1alpha1/flexibleip_cli.go b/internal/namespaces/flexibleip/v1alpha1/flexibleip_cli.go
@@ -101,6 +101,13 @@ func fipIPCreate() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
+			{
+				Name:       "is-ipv6",
+				Short:      `If true, creates a Flexible IP with an ipv6 address`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
 			core.ZoneArgSpec(scw.ZoneFrPar1, scw.ZoneFrPar2, scw.ZoneNlAms1),
 		},
 		Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {