feat(function): add support for node18 (#2335)

Co-authored-by: Rémy Léone <rleone@scaleway.com>
scaleway · Jun 6, 2022 · e5cef4c · e5cef4c
1 parent 762e658
commit e5cef4c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/cmd/scw/testdata/test-all-usage-function-function-create-usage.golden b/cmd/scw/testdata/test-all-usage-function-function-create-usage.golden
@@ -11,7 +11,7 @@ ARGS:
   [environment-variables.value.{key}]            
   [min-scale]                                    
   [max-scale]                                    
-  [runtime]                                       (unknown_runtime | golang | python | python3 | node8 | node10 | node14 | node16 | node17 | python37 | python38 | python39 | python310 | go113 | go117 | go118)
+  [runtime]                                       (unknown_runtime | golang | python | python3 | node8 | node10 | node14 | node16 | node17 | python37 | python38 | python39 | python310 | go113 | go117 | go118 | node18)
   [memory-limit]                                 
   [timeout.seconds]                              
   [timeout.nanos]                                

diff --git a/cmd/scw/testdata/test-all-usage-function-function-update-usage.golden b/cmd/scw/testdata/test-all-usage-function-function-update-usage.golden
@@ -10,7 +10,7 @@ ARGS:
   [environment-variables.value.{key}]            
   [min-scale]                                    
   [max-scale]                                    
-  [runtime]                                       (unknown_runtime | golang | python | python3 | node8 | node10 | node14 | node16 | node17 | python37 | python38 | python39 | python310 | go113 | go117 | go118)
+  [runtime]                                       (unknown_runtime | golang | python | python3 | node8 | node10 | node14 | node16 | node17 | python37 | python38 | python39 | python310 | go113 | go117 | go118 | node18)
   [memory-limit]                                 
   [timeout.seconds]                              
   [timeout.nanos]                                

diff --git a/docs/commands/function.md b/docs/commands/function.md
@@ -118,7 +118,7 @@ scw function function create [arg=value ...]
 | environment-variables.value.{key} |  |  |
 | min-scale |  |  |
 | max-scale |  |  |
-| runtime | One of: `unknown_runtime`, `golang`, `python`, `python3`, `node8`, `node10`, `node14`, `node16`, `node17`, `python37`, `python38`, `python39`, `python310`, `go113`, `go117`, `go118` |  |
+| runtime | One of: `unknown_runtime`, `golang`, `python`, `python3`, `node8`, `node10`, `node14`, `node16`, `node17`, `python37`, `python38`, `python39`, `python310`, `go113`, `go117`, `go118`, `node18` |  |
 | memory-limit |  |  |
 | timeout.seconds |  |  |
 | timeout.nanos |  |  |
@@ -276,7 +276,7 @@ scw function function update <function-id ...> [arg=value ...]
 | environment-variables.value.{key} |  |  |
 | min-scale |  |  |
 | max-scale |  |  |
-| runtime | One of: `unknown_runtime`, `golang`, `python`, `python3`, `node8`, `node10`, `node14`, `node16`, `node17`, `python37`, `python38`, `python39`, `python310`, `go113`, `go117`, `go118` |  |
+| runtime | One of: `unknown_runtime`, `golang`, `python`, `python3`, `node8`, `node10`, `node14`, `node16`, `node17`, `python37`, `python38`, `python39`, `python310`, `go113`, `go117`, `go118`, `node18` |  |
 | memory-limit |  |  |
 | timeout.seconds |  |  |
 | timeout.nanos |  |  |

diff --git a/internal/namespaces/function/v1beta1/function_cli.go b/internal/namespaces/function/v1beta1/function_cli.go
@@ -484,7 +484,7 @@ func functionFunctionCreate() *core.Command {
 				Required:   false,
 				Deprecated: false,
 				Positional: false,
-				EnumValues: []string{"unknown_runtime", "golang", "python", "python3", "node8", "node10", "node14", "node16", "node17", "python37", "python38", "python39", "python310", "go113", "go117", "go118"},
+				EnumValues: []string{"unknown_runtime", "golang", "python", "python3", "node8", "node10", "node14", "node16", "node17", "python37", "python38", "python39", "python310", "go113", "go117", "go118", "node18"},
 			},
 			{
 				Name:       "memory-limit",
@@ -594,7 +594,7 @@ func functionFunctionUpdate() *core.Command {
 				Required:   false,
 				Deprecated: false,
 				Positional: false,
-				EnumValues: []string{"unknown_runtime", "golang", "python", "python3", "node8", "node10", "node14", "node16", "node17", "python37", "python38", "python39", "python310", "go113", "go117", "go118"},
+				EnumValues: []string{"unknown_runtime", "golang", "python", "python3", "node8", "node10", "node14", "node16", "node17", "python37", "python38", "python39", "python310", "go113", "go117", "go118", "node18"},
 			},
 			{
 				Name:       "memory-limit",