Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(account): remove GetLogin #2328

Merged
merged 5 commits into from
May 18, 2022
Merged

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #2328 (1f3148a) into master (48abffd) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2328      +/-   ##
==========================================
+ Coverage   76.18%   76.23%   +0.05%     
==========================================
  Files         125      125              
  Lines       21016    21001      -15     
==========================================
  Hits        16011    16011              
+ Misses       4468     4452      -16     
- Partials      537      538       +1     
Impacted Files Coverage 螖
internal/namespaces/init/init.go 44.76% <0.00%> (+2.29%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 48abffd...1f3148a. Read the comment docs.

kindermoumoute
kindermoumoute previously approved these changes May 17, 2022
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 1f308ab into scaleway:master May 18, 2022
@remyleone remyleone deleted the removal_token_route branch May 18, 2022 15:40
@remyleone remyleone self-assigned this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants