Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli version in docker image #2341

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 7, 2022

Add version arg in Dockerfile
Build with version in build script
add build arg in goreleaser

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Add version arg in Dockerfile
Build with version in build script
add build arg in goreleaser
@codecov-commenter
Copy link

Codecov Report

Merging #2341 (ac9ae36) into master (3f183cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2341   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files         125      125           
  Lines       21046    21046           
=======================================
  Hits        16053    16053           
  Misses       4454     4454           
  Partials      539      539           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3f183cd...ac9ae36. Read the comment docs.

@remyleone remyleone merged commit 1373086 into master Jun 8, 2022
@remyleone remyleone deleted the dockerfile-scw-version branch June 8, 2022 07:46
@remyleone remyleone linked an issue Jun 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix scw version
3 participants