Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize cli loading #2697

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 26, 2022

Base run

 ± time scw -h                
...
scw -h  0.70s user 0.05s system 172% cpu 0.434 total

Current

 ± time ./scw -h              
...
./scw -h  0.15s user 0.04s system 162% cpu 0.114 total

@Codelax Codelax added the core label Dec 26, 2022
@Codelax Codelax self-assigned this Dec 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Merging #2697 (782a538) into master (87eb1a0) will decrease coverage by 0.03%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master    #2697      +/-   ##
==========================================
- Coverage   76.02%   75.98%   -0.04%     
==========================================
  Files         134      134              
  Lines       24749    24767      +18     
==========================================
+ Hits        18816    18820       +4     
- Misses       5303     5317      +14     
  Partials      630      630              
Impacted Files Coverage Δ
internal/core/command.go 52.23% <33.33%> (-4.66%) ⬇️
internal/core/bootstrap.go 72.46% <100.00%> (ø)
internal/core/cobra_builder.go 86.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax
Copy link
Member Author

Codelax commented Dec 26, 2022

After 246cc4f

 ± time ./scw -h
...
./scw -h  0.05s user 0.03s system 119% cpu 0.064 total

@Codelax Codelax marked this pull request as ready for review December 26, 2022 16:15
@remyleone remyleone merged commit b272743 into scaleway:master Dec 26, 2022
@Codelax Codelax deleted the perf/optimize-cli-loading branch December 26, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants