Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): cobra builder allocate with nb of commands and use unordered list #2702

Merged
merged 8 commits into from
Dec 27, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 27, 2022

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added the core label Dec 27, 2022
@Codelax Codelax self-assigned this Dec 27, 2022
@Codelax Codelax changed the title perf(core): allocate maps with number of commands and use unordered list perf(core): cobra builder allocate with nb of commands and use unordered list Dec 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #2702 (280eabf) into master (efb08dd) will decrease coverage by 0.03%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master    #2702      +/-   ##
==========================================
- Coverage   75.55%   75.52%   -0.04%     
==========================================
  Files         134      134              
  Lines       25031    25042      +11     
==========================================
  Hits        18913    18913              
- Misses       5477     5487      +10     
- Partials      641      642       +1     
Impacted Files Coverage 螖
internal/core/cobra_usage_builder.go 55.84% <62.50%> (+0.77%) 猬嗭笍
internal/core/cobra_builder.go 87.50% <100.00%> (+0.40%) 猬嗭笍
internal/core/command.go 44.85% <0.00%> (-5.89%) 猬囷笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone remyleone merged commit 9d30336 into scaleway:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants