Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): change command signature to fix sort of same command #2705

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 27, 2022

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax self-assigned this Dec 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2705 (1bc7c64) into master (fa9a24b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2705   +/-   ##
=======================================
  Coverage   75.56%   75.56%           
=======================================
  Files         134      134           
  Lines       25026    25028    +2     
=======================================
+ Hits        18911    18913    +2     
  Misses       5475     5475           
  Partials      640      640           
Impacted Files Coverage 螖
internal/core/command.go 52.94% <100.00%> (+0.70%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone remyleone merged commit 63d043a into scaleway:master Dec 27, 2022
@Codelax Codelax deleted the fix/sort-stable branch December 27, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants