Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/autocomplete): complete content of args using list verbs #2708

Merged
merged 7 commits into from
Jan 3, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 28, 2022

Keep it as beta for now, could crash completion

Will try to complete arguments using the list verb of the specific resource
Example:
In instance namespace, every server-id will execute instance server list and complete with id fields

In marketplace image get label=, it will fetch for label using list of current resource marketplace image list

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Merging #2708 (a020d9b) into master (e8b781d) will increase coverage by 0.02%.
The diff coverage is 79.01%.

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
+ Coverage   75.00%   75.03%   +0.02%     
==========================================
  Files         134      134              
  Lines       25461    25535      +74     
==========================================
+ Hits        19098    19160      +62     
- Misses       5709     5716       +7     
- Partials      654      659       +5     
Impacted Files Coverage Δ
cmd/scw/main.go 0.00% <0.00%> (ø)
internal/core/autocomplete_utils.go 59.74% <75.40%> (+59.74%) ⬆️
internal/core/autocomplete.go 92.75% <93.75%> (-0.10%) ⬇️
internal/core/bootstrap.go 72.85% <100.00%> (+0.19%) ⬆️
internal/core/context.go 26.59% <100.00%> (+1.59%) ⬆️
internal/core/command.go 48.52% <0.00%> (+3.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax marked this pull request as ready for review January 3, 2023 09:37
Monitob
Monitob previously approved these changes Jan 3, 2023
README.md Show resolved Hide resolved
@remyleone remyleone merged commit 1387dd5 into scaleway:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants