Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): add direction in security-group rule marshal #3015

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Apr 7, 2023

No description provided.

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Apr 7, 2023
@Codelax Codelax self-assigned this Apr 7, 2023
@Codelax Codelax changed the title feat(instance): add direction in security-group list feat(instance): add direction in security-group rule marshal Apr 7, 2023
@remyleone remyleone enabled auto-merge April 7, 2023 13:06
@codecov-commenter
Copy link

Codecov Report

Merging #3015 (ab828f0) into master (aa61053) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3015   +/-   ##
=======================================
  Coverage   75.38%   75.39%           
=======================================
  Files         163      163           
  Lines       34806    34808    +2     
=======================================
+ Hits        26240    26242    +2     
  Misses       7663     7663           
  Partials      903      903           
Impacted Files Coverage Δ
...al/namespaces/instance/v1/custom_security_group.go 55.52% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone remyleone added this pull request to the merge queue Apr 7, 2023
Merged via the queue into scaleway:master with commit c70811c Apr 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants