Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): implement buildpack deploy #3022

Merged
merged 26 commits into from
May 5, 2023

Conversation

quantumsheep
Copy link
Member

@quantumsheep quantumsheep commented Apr 13, 2023

Sizes benchmark

✅ Output executable working
❌ Output executable not working
❓ Output executable not tested

OS Arch go build go build -ldflags "-s -w" go build + upx -9 --lzma go build -ldflags "-s -w" + upx -9 --lzma
darwin amd64 46M 36M 18M ❌ (Segfault) 8.6M ❌ (Segfault)
darwin arm64 46M 36M 21M ❓ 11M ❓
linux 386 45M 31M 18M ❓ 7.6M ❓
linux amd64 47M 33M 19M ✅ 8.2M ✅
linux arm64 44M 31M 17M ❓ 6.7M ❓
windows 386 46M 32M 17M ❓ 7.0M ❓
windows amd64 47M 33M 19M ❓ 8.2M ❓

@quantumsheep quantumsheep added enhancement container Container issues, bugs and feature requests labels Apr 13, 2023
@quantumsheep quantumsheep self-assigned this Apr 13, 2023
@quantumsheep quantumsheep force-pushed the feat/container-deploy-buildpack branch 2 times, most recently from 78e51f8 to a17d05c Compare April 25, 2023 12:37
go.mod Outdated Show resolved Hide resolved
@quantumsheep quantumsheep force-pushed the feat/container-deploy-buildpack branch from cf9a56c to 9ad917d Compare April 26, 2023 09:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #3022 (1decb7a) into master (d0c1da8) will decrease coverage by 0.02%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##           master    #3022      +/-   ##
==========================================
- Coverage   75.77%   75.76%   -0.02%     
==========================================
  Files         169      170       +1     
  Lines       36672    36800     +128     
==========================================
+ Hits        27788    27880      +92     
- Misses       7919     7944      +25     
- Partials      965      976      +11     
Impacted Files Coverage Δ
internal/core/socket_passthrough_transport.go 40.00% <ø> (+3.63%) ⬆️
internal/core/testing_recorder.go 43.63% <40.90%> (+1.96%) ⬆️
...espaces/container/v1beta1/custom_deploy_helpers.go 71.87% <71.87%> (ø)
...rnal/namespaces/container/v1beta1/custom_deploy.go 71.57% <82.00%> (+1.61%) ⬆️

@quantumsheep quantumsheep force-pushed the feat/container-deploy-buildpack branch from c850d96 to e210994 Compare April 28, 2023 09:56
@quantumsheep quantumsheep marked this pull request as ready for review April 28, 2023 09:58
@remyleone remyleone added the priority:high New features label May 2, 2023
@quantumsheep quantumsheep force-pushed the feat/container-deploy-buildpack branch from 1decb7a to 2c90ccb Compare May 5, 2023 12:41
@remyleone remyleone added this pull request to the merge queue May 5, 2023
Merged via the queue into master with commit 7af0b2a May 5, 2023
12 checks passed
@remyleone remyleone deleted the feat/container-deploy-buildpack branch May 5, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Container issues, bugs and feature requests enhancement priority:high New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants