Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an option to hide empty sections #3029

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

quantumsheep
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@quantumsheep quantumsheep self-assigned this Apr 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3029 (67f353c) into master (fbffde8) will decrease coverage by 0.01%.
The diff coverage is 61.11%.

❗ Current head 67f353c differs from pull request most recent head a4f26cb. Consider uploading reports for the commit a4f26cb to get more accurate results

@@            Coverage Diff             @@
##           master    #3029      +/-   ##
==========================================
- Coverage   75.44%   75.43%   -0.01%     
==========================================
  Files         166      166              
  Lines       36260    36276      +16     
==========================================
+ Hits        27355    27366      +11     
- Misses       7954     7959       +5     
  Partials      951      951              
Impacted Files Coverage Δ
internal/core/view.go 0.00% <0.00%> (ø)
internal/human/specs.go 70.00% <ø> (ø)
internal/human/marshal.go 71.34% <73.33%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

remyleone
remyleone previously approved these changes Apr 17, 2023
@remyleone remyleone added this pull request to the merge queue Apr 17, 2023
@Codelax Codelax removed this pull request from the merge queue due to a manual request Apr 17, 2023
internal/core/view.go Show resolved Hide resolved
@remyleone remyleone added this pull request to the merge queue Apr 17, 2023
Merged via the queue into master with commit 9dc1772 Apr 17, 2023
12 checks passed
@remyleone remyleone deleted the feat/marshal-hide-if-empty branch April 17, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants