Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): global flag profile values #3036

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Apr 17, 2023

Closes #3006

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #3036 (d4d04da) into master (6406bad) will increase coverage by 0.00%.
The diff coverage is 95.83%.

@@           Coverage Diff           @@
##           master    #3036   +/-   ##
=======================================
  Coverage   75.45%   75.45%           
=======================================
  Files         166      166           
  Lines       36266    36282   +16     
=======================================
+ Hits        27363    27376   +13     
- Misses       7953     7956    +3     
  Partials      950      950           
Impacted Files Coverage Δ
internal/core/client.go 0.00% <0.00%> (ø)
internal/core/autocomplete.go 91.26% <100.00%> (-0.73%) ⬇️
internal/core/autocomplete_utils.go 75.20% <100.00%> (+11.24%) ⬆️
internal/core/context.go 31.81% <100.00%> (+2.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax marked this pull request as ready for review April 18, 2023 08:21
@remyleone remyleone added this pull request to the merge queue Apr 18, 2023
Merged via the queue into scaleway:master with commit 2dfca5d Apr 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have autocompletion on profile name
3 participants