feat(init): no overwrite prompt when adding a new profile #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codelax
force-pushed
the
feat/init-no-overwrite-for-new-profiles
branch
from
9dc1302
to
aa56c5a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3097 +/- ##
=======================================
Coverage 75.79% 75.80%
=======================================
Files 169 169
Lines 36631 36638 +7
=======================================
+ Hits 27765 27772 +7
Misses 7903 7903
Partials 963 963
|
remyleone
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for init rework #2792
Lookup #2792 (comment)
Now we get an override prompt only when doing init for an existing profile. There is not prompt for
scw init -p mynewprofileAlso the override prompt has changed, it only print the profile that will be override instead of the whole config