Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): positional argument #759

Merged
merged 11 commits into from Mar 11, 2020
Merged

feat(core): positional argument #759

merged 11 commits into from Mar 11, 2020

Conversation

kindermoumoute
Copy link
Contributor

No description provided.

QuentinBrosse
QuentinBrosse suggested changes Mar 10, 2020
View reviewed changes
internal/core/arg_specs.go Show resolved Hide resolved
internal/core/cobra_utils.go Outdated Show resolved Hide resolved
internal/core/cobra_utils.go Outdated Show resolved Hide resolved
internal/core/cobra_utils.go Outdated Show resolved Hide resolved
internal/core/cobra_utils.go Outdated Show resolved Hide resolved
internal/core/cobra_utils.go Outdated Show resolved Hide resolved
kindermoumoute and others added 6 commits March 10, 2020 17:28
@kindermoumoute @QuentinBrosse
Update internal/core/cobra_utils.go
2bb3c7f 
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
@kindermoumoute @QuentinBrosse
Update internal/core/cobra_utils.go
0f86f6a 
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
@kindermoumoute @QuentinBrosse
Update internal/core/cobra_utils.go
4601530 
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
@kindermoumoute @QuentinBrosse
Update internal/core/cobra_utils.go
ae8b445 
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
@kindermoumoute
address quentin's comment
3222569
@kindermoumoute
forbid 2 positional args
ee4be8b
loicbourgois
loicbourgois suggested changes Mar 11, 2020
View reviewed changes
internal/core/arg_specs.go Outdated Show resolved Hide resolved
internal/core/arg_specs.go Outdated Show resolved Hide resolved
internal/core/testdata/test-positional-arg-full-command#01.stderr.golden Outdated Show resolved Hide resolved
internal/core/cobra_utils_test.go Show resolved Hide resolved
kindermoumoute and others added 2 commits March 11, 2020 10:32
@kindermoumoute @loicbourgois
Apply suggestions from code review
dd63baf 
Co-Authored-By: Loïc Bourgois <loic@bourgois.pro>
@kindermoumoute
document positional to be required
d8f24e4
loicbourgois
loicbourgois approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuentinBrosse
QuentinBrosse approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit 2dbe16f into scaleway:v2 Mar 11, 2020
@kindermoumoute kindermoumoute deleted the positional-parameter branch March 11, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@loicbourgois loicbourgois loicbourgois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kindermoumoute @QuentinBrosse @loicbourgois @golangcibot