fix(instance_image): test concurrency issue with cassettes (#1378)

* fix(instance_image): test concurrency issue with cassettes * split ServerWithBlockVolume test
scaleway · Jul 20, 2022 · 3e84b5a · 3e84b5a
1 parent b67c3a0
commit 3e84b5a
Show file tree

Hide file tree

Showing 3 changed files with 4,469 additions and 2,622 deletions.
diff --git a/scaleway/resource_instance_image_test.go b/scaleway/resource_instance_image_test.go
@@ -192,6 +192,29 @@ func TestAccScalewayInstanceImage_ServerWithBlockVolume(t *testing.T) {
 			testAccCheckScalewayInstanceServerDestroy(tt),
 		),
 		Steps: []resource.TestStep{
+			{
+				Config: `
+					resource "scaleway_instance_volume" "block01" {
+						type       = "b_ssd"
+						size_in_gb = 21
+					}
+					resource "scaleway_instance_snapshot" "block01" {
+						volume_id	= scaleway_instance_volume.block01.id
+						depends_on 	= [ scaleway_instance_volume.block01 ]
+					}
+
+					resource "scaleway_instance_server" "server" {
+						image	= "ubuntu_focal"
+						type 	= "DEV1-S"
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayInstanceVolumeExists(tt, "scaleway_instance_volume.block01"),
+					testAccCheckScalewayInstanceServerExists(tt, "scaleway_instance_server.server"),
+					testAccCheckScalewayInstanceSnapShotExists(tt, "scaleway_instance_snapshot.block01"),
+				),
+			},
+
 			{
 				Config: `
 					resource "scaleway_instance_volume" "block01" {
@@ -302,7 +325,7 @@ func TestAccScalewayInstanceImage_ServerWithBlockVolume(t *testing.T) {
 func TestAccScalewayInstanceImage_ServerWithLocalVolume(t *testing.T) {
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: tt.ProviderFactories,
 		CheckDestroy: resource.ComposeTestCheckFunc(
@@ -312,6 +335,61 @@ func TestAccScalewayInstanceImage_ServerWithLocalVolume(t *testing.T) {
 			testAccCheckScalewayInstanceServerDestroy(tt),
 		),
 		Steps: []resource.TestStep{
+			{
+				Config: `
+					resource "scaleway_instance_server" "server01" {
+						image	= "ubuntu_focal"
+						type 	= "DEV1-S"
+						root_volume {
+							size_in_gb = 15
+							volume_type = "l_ssd"
+						}
+					}
+					resource "scaleway_instance_snapshot" "local01" {
+						volume_id = scaleway_instance_server.server01.root_volume.0.volume_id
+						depends_on = [ scaleway_instance_server.server01 ]
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayInstanceServerExists(tt, "scaleway_instance_server.server01"),
+					testAccCheckScalewayInstanceSnapShotExists(tt, "scaleway_instance_snapshot.local01"),
+				),
+			},
+			{
+				Config: `
+					resource "scaleway_instance_server" "server01" {
+						image	= "ubuntu_focal"
+						type 	= "DEV1-S"
+						root_volume {
+							size_in_gb = 15
+							volume_type = "l_ssd"
+						}
+					}
+					resource "scaleway_instance_server" "server02" {
+						image	= "ubuntu_focal"
+						type 	= "DEV1-S"
+						root_volume {
+							size_in_gb = 10
+							volume_type = "l_ssd"
+						}
+					}
+
+					resource "scaleway_instance_snapshot" "local01" {
+						volume_id = scaleway_instance_server.server01.root_volume.0.volume_id
+						depends_on = [ scaleway_instance_server.server01 ]
+					}
+					resource "scaleway_instance_snapshot" "local02" {
+						volume_id = scaleway_instance_server.server02.root_volume.0.volume_id
+						depends_on = [ scaleway_instance_server.server02 ]
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayInstanceServerExists(tt, "scaleway_instance_server.server01"),
+					testAccCheckScalewayInstanceServerExists(tt, "scaleway_instance_server.server02"),
+					testAccCheckScalewayInstanceSnapShotExists(tt, "scaleway_instance_snapshot.local01"),
+					testAccCheckScalewayInstanceSnapShotExists(tt, "scaleway_instance_snapshot.local02"),
+				),
+			},
 			{
 				Config: `
 					resource "scaleway_instance_server" "server01" {