fix(instance): fix empty tags list (#1136)

scaleway/resource_instance_security_group.go

@@ -109,7 +109,7 @@ func resourceScalewayInstanceSecurityGroupCreate(ctx context.Context, d *schema.
 		return diag.FromErr(err)
 	}
 
-	res, err := instanceAPI.CreateSecurityGroup(&instance.CreateSecurityGroupRequest{
+	req := &instance.CreateSecurityGroupRequest{
 		Name:                  expandOrGenerateString(d.Get("name"), "sg"),
 		Zone:                  zone,
 		Project:               expandStringPtr(d.Get("project_id")),
@@ -119,7 +119,8 @@ func resourceScalewayInstanceSecurityGroupCreate(ctx context.Context, d *schema.
 		OutboundDefaultPolicy: instance.SecurityGroupPolicy(d.Get("outbound_default_policy").(string)),
 		EnableDefaultSecurity: expandBoolPtr(d.Get("enable_default_security")),
 		Tags:                  expandStrings(d.Get("tags")),
-	}, scw.WithContext(ctx))
+	}
+	res, err := instanceAPI.CreateSecurityGroup(req, scw.WithContext(ctx))
 	if err != nil {
 		return diag.FromErr(err)
 	}
@@ -263,16 +264,13 @@ func resourceScalewayInstanceSecurityGroupUpdate(ctx context.Context, d *schema.
 		Description:           expandStringPtr(description),
 		InboundDefaultPolicy:  &inboundDefaultPolicy,
 		OutboundDefaultPolicy: &outboundDefaultPolicy,
+		Tags:                  scw.StringsPtr(expandStrings(d.Get("tags"))),
 	}
 
 	if d.HasChange("enable_default_security") {
 		updateReq.EnableDefaultSecurity = expandBoolPtr(d.Get("enable_default_security"))
 	}
 
-	if d.HasChange("tags") {
-		updateReq.Tags = scw.StringsPtr(expandStrings(d.Get("tags")))
-	}
-
 	// Only update name if one is provided in the state
 	if d.Get("name") != nil && d.Get("name").(string) != "" {
 		updateReq.Name = expandStringPtr(d.Get("name"))

scaleway/resource_instance_snapshot.go

@@ -126,15 +126,8 @@ func resourceScalewayInstanceSnapshotUpdate(ctx context.Context, d *schema.Resou
 	req := &instance.UpdateSnapshotRequest{
 		SnapshotID: id,
 		Zone:       zone,
-	}
-
-	if d.HasChange("name") {
-		newName := d.Get("name").(string)
-		req.Name = &newName
-	}
-
-	if d.HasChange("tags") {
-		req.Tags = scw.StringsPtr(expandStrings(d.Get("tags")))
+		Tags:       scw.StringsPtr(expandStrings(d.Get("tags"))),
+		Name:       scw.StringPtr(d.Get("name").(string)),
 	}
 
 	_, err = instanceAPI.UpdateSnapshot(req, scw.WithContext(ctx))