Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(domain): avoid root zone deletion attempt #1092

Merged
merged 5 commits into from Feb 15, 2022
Merged

Conversation

jerjako
Copy link
Contributor

@jerjako jerjako commented Feb 15, 2022

No description provided.

@jerjako jerjako linked an issue Feb 15, 2022 that may be closed by this pull request
@scaleway-bot scaleway-bot changed the title fix: don't try do delete a root zone fix(domain): avoid root zone deletion attempt Feb 15, 2022
@Monitob
Copy link
Contributor

Monitob commented Feb 15, 2022

@jerjako looks good this PR, but you need to remake the cassettes.

@Monitob Monitob merged commit 0c3fd08 into master Feb 15, 2022
@Monitob Monitob deleted the fix_domain_root_zone branch February 15, 2022 15:38
remyleone pushed a commit to remyleone/terraform-provider-scaleway that referenced this pull request Mar 28, 2022
@remyleone remyleone added the domain Domains issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Domains issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard domain record issue
4 participants