Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(container): add resource containers as service #1103

Merged
merged 25 commits into from Mar 31, 2022
Merged

feat(container): add resource containers as service #1103

merged 25 commits into from Mar 31, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Feb 22, 2022

No description provided.

@Monitob Monitob added this to the v2.3.0 milestone Feb 22, 2022
@Monitob Monitob self-assigned this Feb 22, 2022
@Monitob Monitob marked this pull request as draft February 22, 2022 11:14
remyleone
remyleone reviewed Feb 23, 2022
View reviewed changes
scaleway/provider.go Outdated Show resolved Hide resolved
@Monitob Monitob force-pushed the feat-add-resource-containers-as-service branch from 808ec68 to d399a16 Compare March 1, 2022 09:41
@Monitob Monitob linked an issue Mar 7, 2022 that may be closed by this pull request
add support for container as a service #979
Closed
@Monitob Monitob force-pushed the feat-add-resource-containers-as-service branch from 1a62bff to c20069a Compare March 8, 2022 10:17
@remyleone remyleone added this to To do in Main Mar 9, 2022
@remyleone remyleone moved this from To do to In progress in Main Mar 9, 2022
@Monitob Monitob force-pushed the feat-add-resource-containers-as-service branch 2 times, most recently from fbee80d to 5f62ee8 Compare March 11, 2022 15:07
@Monitob Monitob mentioned this pull request Mar 11, 2022
Closed
7 tasks
@remyleone remyleone changed the title Feat(container): add resource containers as service feat(container): add resource containers as service Mar 11, 2022
@Monitob Monitob force-pushed the feat-add-resource-containers-as-service branch from 5f62ee8 to d5adb0f Compare March 14, 2022 16:56
@Monitob Monitob marked this pull request as ready for review March 14, 2022 16:58
@Monitob Monitob marked this pull request as draft March 14, 2022 17:08
@Monitob Monitob force-pushed the feat-add-resource-containers-as-service branch 5 times, most recently from 2ecfb4b to d33f475 Compare March 15, 2022 10:55
@Monitob Monitob marked this pull request as ready for review March 15, 2022 11:01
@Monitob Monitob requested a review from remyleone March 15, 2022 11:01
@Monitob Monitob moved this from In progress to Review in progress in Main Mar 15, 2022
remyleone
remyleone reviewed Mar 15, 2022
View reviewed changes
docs/data-sources/container.md Outdated Show resolved Hide resolved
docs/data-sources/container.md Outdated Show resolved Hide resolved
docs/data-sources/container.md Outdated Show resolved Hide resolved
docs/data-sources/container.md Outdated Show resolved Hide resolved
docs/data-sources/container.md Show resolved Hide resolved
scaleway/resource_container.go Outdated Show resolved Hide resolved
scaleway/resource_container.go Outdated Show resolved Hide resolved
scaleway/resource_container.go Outdated Show resolved Hide resolved
scaleway/resource_container.go Outdated Show resolved Hide resolved
scaleway/resource_container_test.go Outdated Show resolved Hide resolved
@Monitob Monitob force-pushed the feat-add-resource-containers-as-service branch 2 times, most recently from f9482e6 to f32292f Compare March 17, 2022 15:28
@Monitob Monitob requested a review from remyleone March 17, 2022 15:34
Monitob and others added 20 commits March 22, 2022 13:54
@Monitob
feat(containers): add check for environment variables
1102e6a
@Monitob @remyleone
Update scaleway/provider.go
f4d0d15 
Co-authored-by: Rémy Léone <remy.leone@gmail.com>
@Monitob
feat(container): add container helpers and resources
76a1877
@Monitob
feat(containers): remove handler container and add read/update and ne…
cea6d3f 
…w attributes
@Monitob
feat(containers): add container test
3f9f44f
@Monitob
feat(containers): add helpers
3591841
@Monitob
feat(containers): add containers default values and descriptions
ababec6
@Monitob
feat(containers): bump cassettes
d1b9456
@Monitob
feat(container): add container test with registry image
bcca45b
@Monitob
feat(container): add docker test
467c5f6
@Monitob
chore: add cassette test containers with image
d9e3de0
@Monitob
fix(containers): helpers
ebfafa5
@Monitob
fix(containers): read corrections
75d498a
@Monitob
fix(test): add cassettes
97c4581
@Monitob
bump depencencies
30bb74d
@Monitob
feat(container): add cassettes
c540fa3
@Monitob
feat(container): add datasource container
676e2e3
@Monitob
feat(container): add documentation for resource and datasource
fdf3d40
@Monitob
feat(container) add push image on registry and enhancements
051e273 
Co-authored-by: Rémy Léone <remy.leone@gmail.com>

Update scaleway/resource_container.go

Co-authored-by: Rémy Léone <remy.leone@gmail.com>

Update scaleway/resource_container.go

Co-authored-by: Rémy Léone <remy.leone@gmail.com>

Update scaleway/resource_container.go

Co-authored-by: Rémy Léone <remy.leone@gmail.com>

Update scaleway/resource_container.go

Co-authored-by: Rémy Léone <remy.leone@gmail.com>

Update scaleway/resource_container.go

Co-authored-by: Rémy Léone <remy.leone@gmail.com>

fix(containers): add documentation and enhance resource
@Monitob
fix(docs): resource/data_source
84ab3b9
@Monitob Monitob force-pushed the feat-add-resource-containers-as-service branch from fa49b11 to 84ab3b9 Compare March 22, 2022 12:54
@codecov-commenter
Copy link

Codecov Report

Merging #1103 (84ab3b9) into master (d6af511) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1103      +/-   ##
=========================================
- Coverage    1.60%   1.55%   -0.05%     
=========================================
  Files          91      93       +2     
  Lines       14660   15127     +467     
=========================================
  Hits          235     235              
- Misses      14402   14869     +467     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/data_source_container.go 0.00% <0.00%> (ø)
scaleway/helpers.go 15.09% <0.00%> (-0.49%) ⬇️
scaleway/helpers_container.go 0.00% <0.00%> (ø)
scaleway/helpers_registry.go 0.00% <ø> (ø)
scaleway/provider.go 18.30% <0.00%> (-0.17%) ⬇️
scaleway/resource_container.go 0.00% <0.00%> (ø)
scaleway/resource_container_namespace.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6af511...84ab3b9. Read the comment docs.

Main automation moved this from Review in progress to Reviewer approved Mar 28, 2022
@Monitob Monitob merged commit ece780e into scaleway:master Mar 31, 2022
Main automation moved this from Reviewer approved to Done Mar 31, 2022
@Monitob Monitob deleted the feat-add-resource-containers-as-service branch March 31, 2022 12:03
@remyleone remyleone added the container Container issues, bugs and feature requests label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Monitob Monitob

Labels
container Container issues, bugs and feature requests enhancement
Projects
No open projects
Main
Done
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

add support for container as a service
3 participants
@Monitob @codecov-commenter @remyleone