Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lb): add support for certificates id list #1152

Merged
merged 5 commits into from Mar 28, 2022
Merged

feat(lb): add support for certificates id list #1152

merged 5 commits into from Mar 28, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Mar 25, 2022

No description provided.

@Monitob Monitob marked this pull request as draft March 25, 2022 09:59
@Monitob Monitob force-pushed the feat-add-lb-frontend-certificate branch from 7c347cd to ac1137a Compare March 25, 2022 13:25
@Monitob Monitob marked this pull request as ready for review March 25, 2022 13:26
@Monitob Monitob requested a review from remyleone March 25, 2022 13:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022 •
edited

Codecov Report

Merging #1152 (f260c96) into master (a7a0584) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head f260c96 differs from pull request most recent head 473ec5a. Consider uploading reports for the commit 473ec5a to get more accurate results

@@            Coverage Diff            @@
##           master   #1152      +/-   ##
=========================================
- Coverage    1.60%   1.59%   -0.01%     
=========================================
  Files          91      91              
  Lines       14660   14694      +34     
=========================================
  Hits          235     235              
- Misses      14402   14436      +34     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/helpers.go 14.92% <0.00%> (-0.66%) ⬇️
scaleway/resource_lb_frontend.go 2.86% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a0584...473ec5a. Read the comment docs.

@Monitob Monitob linked an issue Mar 25, 2022 that may be closed by this pull request
Load-balancer frontend support multiple certificate Ids #845
Closed
remyleone
remyleone reviewed Mar 25, 2022
View reviewed changes
scaleway/helpers.go Outdated Show resolved Hide resolved
scaleway/resource_lb_frontend_test.go Outdated Show resolved Hide resolved
docs/resources/lb_frontend.md Outdated Show resolved Hide resolved
Monitob and others added 3 commits March 28, 2022 10:27
@Monitob @remyleone
Update docs/resources/lb_frontend.md
f260c96 
Co-authored-by: Rémy Léone <remy.leone@gmail.com>
@Monitob @remyleone
Update scaleway/helpers.go
473ec5a 
Co-authored-by: Rémy Léone <remy.leone@gmail.com>
@Monitob
feat(lb-frontend): add example with two certificates
506944a
@Monitob Monitob force-pushed the feat-add-lb-frontend-certificate branch from 6e253b1 to 506944a Compare March 28, 2022 13:20
@remyleone remyleone changed the title feat(lb-frontend): add certificates collection feat(lb): add support for certificates id list Mar 28, 2022
@Monitob Monitob merged commit 0333377 into scaleway:master Mar 28, 2022
@Monitob Monitob deleted the feat-add-lb-frontend-certificate branch March 28, 2022 13:30
@remyleone remyleone added the load-balancer Load-balancer issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees
No one assigned
Labels
load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load-balancer frontend support multiple certificate Ids
3 participants
@Monitob @codecov-commenter @remyleone