Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dhcp-reservation): add resource dhcp reservation #1156

Merged
merged 7 commits into from Apr 4, 2022
Merged

feat(dhcp-reservation): add resource dhcp reservation #1156

merged 7 commits into from Apr 4, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Mar 29, 2022

No description provided.

@Monitob Monitob self-assigned this Mar 29, 2022
@Monitob Monitob marked this pull request as draft March 29, 2022 13:41
@Monitob Monitob linked an issue Mar 29, 2022 that may be closed by this pull request
Allow define DHCP static associations #1036
Closed
@Monitob Monitob force-pushed the feat-add-resource-vpc-public-gateway-dhcp-entry branch from fe294f0 to 2b6f24d Compare March 31, 2022 14:09
@Monitob Monitob marked this pull request as ready for review March 31, 2022 14:09
@Monitob Monitob requested a review from remyleone March 31, 2022 14:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022 •
edited

Codecov Report

Merging #1156 (37e289d) into master (8f586fd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1156      +/-   ##
=========================================
- Coverage    1.53%   1.52%   -0.02%     
=========================================
  Files          94      95       +1     
  Lines       15265   15432     +167     
=========================================
  Hits          235     235              
- Misses      15007   15174     +167     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/provider.go 18.14% <0.00%> (-0.09%) ⬇️
...ay/resource_vpc_public_gateway_dhcp_reservation.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f586fd...37e289d. Read the comment docs.

Monitob and others added 2 commits April 4, 2022 11:43
@Monitob @remyleone
Update docs/resources/vpc_public_gateway_dhcp_reservation.md
1882db9 
Co-authored-by: Rémy Léone <remy.leone@gmail.com>
@Monitob @remyleone
Update scaleway/resource_vpc_public_gateway_dhcp_reservation.go
37e289d 
Co-authored-by: Rémy Léone <remy.leone@gmail.com>
@Monitob Monitob merged commit deaa2c0 into scaleway:master Apr 4, 2022
@Monitob Monitob deleted the feat-add-resource-vpc-public-gateway-dhcp-entry branch April 4, 2022 11:36
@remyleone remyleone added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Monitob Monitob

Labels
vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow define DHCP static associations
3 participants
@Monitob @codecov-commenter @remyleone