Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(baremetal): add configurable timeout #1164

Merged
merged 5 commits into from Apr 6, 2022

Conversation

remyleone
Copy link
Member

@remyleone remyleone commented Apr 5, 2022

# sieben @ sieben-macbook in ~/sandbox_tf [14:12:26] 
$ terraform apply
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - scaleway/scaleway in /Users/sieben/workspace/terraform-provider-scaleway
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with published releases.
╵

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # scaleway_baremetal_server.main will be created
  + resource "scaleway_baremetal_server" "main" {
      + domain          = (known after apply)
      + id              = (known after apply)
      + ips             = (known after apply)
      + name            = (known after apply)
      + offer           = "EM-L101X-SATA"
      + offer_id        = (known after apply)
      + organization_id = (known after apply)
      + os              = "d17d6872-0412-45d9-a198-af82c34d3c5c"
      + os_id           = (known after apply)
      + project_id      = (known after apply)
      + ssh_key_ids     = [
          + "495d0e9f-a22b-4ff5-8324-0cb4746c57dc",
        ]
      + zone            = "fr-par-2"

      + timeouts {
          + create = "10s"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

scaleway_baremetal_server.main: Creating...
scaleway_baremetal_server.main: Still creating... [10s elapsed]
╷
│ Error: scaleway-sdk-go: waiting for server failed: timeout after 10s
│ 
│   with scaleway_baremetal_server.main,
│   on main.tf line 17, in resource "scaleway_baremetal_server" "main":
│   17: resource "scaleway_baremetal_server" "main" {
│ 

@remyleone remyleone linked an issue Apr 5, 2022 that may be closed by this pull request
Monitob
Monitob previously approved these changes Apr 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1164 (b8f8b1c) into master (6f542ac) will not change coverage.
The diff coverage is 0.00%.

❗ Current head b8f8b1c differs from pull request most recent head ac43ecf. Consider uploading reports for the commit ac43ecf to get more accurate results

@@          Coverage Diff           @@
##           master   #1164   +/-   ##
======================================
  Coverage    1.52%   1.52%           
======================================
  Files          95      95           
  Lines       15447   15447           
======================================
  Hits          235     235           
  Misses      15189   15189           
  Partials       23      23           
Impacted Files Coverage Δ
scaleway/resource_baremetal_server.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f542ac...ac43ecf. Read the comment docs.

@remyleone remyleone merged commit 326c8de into scaleway:master Apr 6, 2022
@remyleone remyleone deleted the baremetal_timeout branch April 6, 2022 14:14
@remyleone remyleone added the elastic-metal Elastic-metal issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elastic-metal Elastic-metal issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeout to Baremetal server
3 participants