Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rdb-acl): tags, ACL description attribute and documentation #1180

Merged
merged 6 commits into from Apr 6, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Apr 5, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1180 (7ab8ce0) into master (deaa2c0) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1180      +/-   ##
=========================================
- Coverage    1.52%   1.52%   -0.01%     
=========================================
  Files          95      95              
  Lines       15432   15440       +8     
=========================================
  Hits          235     235              
- Misses      15174   15182       +8     
  Partials       23      23              
Impacted Files Coverage Δ
scaleway/resource_instance_ip.go 0.00% <0.00%> (ø)
scaleway/resource_rdb_acl.go 0.00% <0.00%> (ø)
scaleway/resource_rdb_instance.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deaa2c0...7ab8ce0. Read the comment docs.

docs/resources/rdb_acl.md Outdated Show resolved Hide resolved
scaleway/resource_rdb_instance.go Outdated Show resolved Hide resolved
Monitob and others added 2 commits April 6, 2022 09:59
@Monitob Monitob requested a review from remyleone April 6, 2022 09:34
@Monitob Monitob linked an issue Apr 6, 2022 that may be closed by this pull request
@remyleone remyleone merged commit 487d9d6 into scaleway:master Apr 6, 2022
@Monitob Monitob deleted the fix-rdb-acl-rules branch April 6, 2022 15:33
@remyleone remyleone added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL rules does not converge
3 participants