Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object): fix cors update test #1319

Merged
merged 4 commits into from Jun 6, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 6, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #1319 (d449bb0) into master (8033c72) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1319   +/-   ##
=======================================
  Coverage   69.96%   69.96%           
=======================================
  Files         102      102           
  Lines       16316    16316           
=======================================
  Hits        11415    11415           
  Misses       3922     3922           
  Partials      979      979           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8033c72...d449bb0. Read the comment docs.

remove manual s3 usage and update state using terraform resource
@Codelax Codelax changed the title fix(object): fix cors update test resource name fix(object): fix cors update test Jun 6, 2022
@remyleone remyleone merged commit d4210a1 into scaleway:master Jun 6, 2022
remyleone added a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
* fix(object): fix cors update test resource name

* test(object): simplify cors update test
remove manual s3 usage and update state using terraform resource

Co-authored-by: Rémy Léone <rleone@scaleway.com>
@remyleone remyleone added the object Object storage issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object Object storage issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants