Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add timeout values in schema when they're being used #1320

Merged
merged 1 commit into from Jun 6, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 6, 2022

Fix #1313

@codecov-commenter
Copy link

Codecov Report

Merging #1320 (70dbbf1) into master (8033c72) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
+ Coverage   69.96%   70.15%   +0.19%     
==========================================
  Files         102      102              
  Lines       16316    16422     +106     
==========================================
+ Hits        11415    11521     +106     
  Misses       3922     3922              
  Partials      979      979              
Impacted Files Coverage Δ
scaleway/resource_apple_silicon_server.go 45.03% <100.00%> (+0.36%) ⬆️
scaleway/resource_baremetal_server.go 69.91% <100.00%> (+0.37%) ⬆️
scaleway/resource_container_namespace.go 73.50% <100.00%> (+0.72%) ⬆️
scaleway/resource_domain_record.go 83.73% <100.00%> (+0.13%) ⬆️
scaleway/resource_function_namespace.go 71.42% <100.00%> (+0.79%) ⬆️
scaleway/resource_instance_private_nic.go 47.30% <100.00%> (+1.29%) ⬆️
scaleway/resource_instance_server.go 72.85% <100.00%> (+0.13%) ⬆️
scaleway/resource_instance_snapshot.go 73.85% <100.00%> (+0.34%) ⬆️
scaleway/resource_instance_volume.go 74.88% <100.00%> (+0.34%) ⬆️
scaleway/resource_iot_network.go 80.76% <100.00%> (+0.61%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8033c72...70dbbf1. Read the comment docs.

@remyleone remyleone merged commit 00f0991 into scaleway:master Jun 6, 2022
remyleone pushed a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeouts other than default cannot be override
4 participants