Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serverless): add support for native domain name #1358

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

remyleone
Copy link
Member

No description provided.

@@ -84,6 +84,8 @@ The following arguments are optional:

- `deploy` - (Optional) Boolean controlling whether the container is on a production environment.

- `domain_name` - The native domain name of the container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only computed, should be in exported attributes

@@ -77,6 +77,8 @@ The following arguments are supported:

- `zip_file` - Location of the zip file to upload containing your function sources

- `domain_name` - The native domain name of the function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only computed, should be in exported attributes

@remyleone remyleone merged commit b367b47 into scaleway:master Jul 7, 2022
@remyleone remyleone deleted the container_domain branch July 7, 2022 08:12
Mia-Cross pushed a commit to Mia-Cross/terraform-provider-scaleway that referenced this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants